Changing customconfig from int32 to int64 #2324
Conversation
|
@sergey-shandar can you please have a look at this |
|
@q3blend Are you aware that this will introduce SDK breaking changes for statically-types languages such C#, Java and Go? |
sergey-shandar
added
WaitForARMFeedback
|
@ravbhatnagar could you look to the changes? |
| @@ -103,7 +103,7 @@ | |||
| "description": "The identifier for the custom search configuration", | |||
| "required": true, | |||
| "type": "integer", | |||
| "format": "int32" | |||
| "format": "int64" | |||
There was a problem hiding this comment.
@q3blend your intention is to mimic uint here, so it will be better if you also take advantage of minimum/maximum attributes.
Adding minimum value to customConfig
|
This commit was treated and no generation was made for Azure/azure-sdk-for-python |
|
This commit was treated and no generation was made for Azure/azure-sdk-for-go |
|
Added minimum value. I am aware this is a breaking change, but the current version is broken for 50% of the custom search instances, so it is a change we must make. |
sergey-shandar
removed
the
WaitForARMFeedback
|
@q3blend could you also provide an example which has this parameter to fix this issue https://travis-ci.org/Azure/azure-rest-api-specs/jobs/337527734 ? |
There was a problem hiding this comment.
we need an example https://travis-ci.org/Azure/azure-rest-api-specs/jobs/337527734
Adding customConfig to the example parameters
Automation for azure-sdk-for-pythonWas unable to create SDK azure-sdk-for-python PR for this closed PR. |
|
This commit was treated and no generation was made for Azure/azure-sdk-for-go |
1 similar comment
|
This commit was treated and no generation was made for Azure/azure-sdk-for-go |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
1 similar comment
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
This commit was treated and no generation was made for Azure/azure-sdk-for-go |
Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger